Revision History¶
v5.8.0¶
Major changes:
Improved
AsyncS3Bucket
:- Read environment variable
S3_ENDPOINT_URL
to obtain the endpoint URL. This allows use with non-AWS S3 servers. - Added support for running a mock S3 server: a new
domock
constructor argument andAsyncS3Bucket.stop_mock
method. This is intended for CSCs running in simulation mode, and for unit tests. - Added static method
AsyncS3Bucket.make_bucket_name
. - Added static method
AsyncS3Bucket.make_key
.
- Read environment variable
Improved
BaseCscTestCase
:- Added argument
skip_commands
toBaseCscTestCase.check_standard_state_transitions
. - Added argument
**kwargs
toBaseCscTestCase.make_csc
andBaseCscTestCase.basic_make_csc
. - Changed argument
*cmdline_args
tocmdline_args
forBaseCscTestCase.check_bin_script
, for clarity.
- Added argument
Other changes:
- Added a Configuring ts_salobj section to the documentation.
- Added missing unit test for
topics.QueueCapacityChecker
. - Standardized the formatting for attributes documented in the Notes section for some classes.
Requirements:
- ts_idl 1
- ts_xml 4.7
- IDL files for Test, Script, and LOVE.
- SALPY_Test generated by ts_sal 4 (for unit tests)
v5.7.0¶
Major changes:
- Added
astropy_time_from_tai_unix
function. - Added
CscCommander
to support exercising CSCs from trivial command-line scripts (DM-23771). - Added
bin/zrun_test_commander.py
to exerciseCscCommander
. - Added
stream_as_generator
to support reading user input from asyncio-based interactive command-line scripts, such as CSC commanders. - The package is now conda-installable.
- Added constants
LOCAL_HOST
,SECONDS_PER_DAY
andMJD_MINUS_UNIX_SECONDS
.
Other changes:
Set the
name
field oflogMessage
, if available (DM-23812).Fixed two issues in
tai_from_utc
when provided with anastropy.time.Time
.- Using the default value for the
scale
argument caused incorrect behavior. Now thescale
argument is ignored, as it should be, since astropy time’s have their own scale. - The behavior on a leap second day was not well documented and differed from
astropy.time
. Document it and matchastropy.time
.
- Using the default value for the
Improved logging for queues filling up, especially the DDS queue (DM-23802).
Prevent
BaseScript
from being constructed with index=0, because such a script would receive commands for every script (DM-23900).Fixed a bug in
ConfigurableCsc.begin_start
that could result in an undefined variable when trying to print an error message.Load the astropy leap second table at startup, so the first call to
current_tai
is fast.Use
time.monotonic
instead oftime.time
to measure durations.
Requirements:
- ts_idl 1
- ts_xml 4.7
- IDL files for Test, Script, and LOVE.
- SALPY_Test generated by ts_sal 4 (for unit tests)
v5.6.0¶
Major changes:
- Added
BaseConfigTestCase
to support testing configuration files in ts_config_x packages.
Requirements:
- black
- ts_idl 1
- ts_xml 4.7
- IDL files for Test, Script, and LOVE.
- SALPY_Test generated by ts_sal 4 (for unit tests)
v5.5.0¶
Major changes:
- Scripts now launch with master priority 0 (or will, once https://jira.lsstcorp.org/browse/DM-23462 is implemented). This should make scripts launch more quickly.
Requirements:
- black
- ts_idl 1
- ts_xml 4.7
- IDL files for Test, Script, and LOVE.
- SALPY_Test generated by ts_sal 4 (for unit tests)
v5.4.0¶
Major changes:
Add support for the new
setGroupId
Script
command toBaseScript
:- Scripts must now have a non-blank group ID before they are run.
- Add
BaseScript.group_id
property. - Add
BaseScript.next_supplemented_group_id
method.
Changed
BaseScript.do_resume
andBaseScript.do_setCheckpoints
to asynchronous, so alldo_...
methods are asynchronous, for consistency. I did not find any code outside of ts_salobj that was affected, but it is a potentially breaking change.Output fields added to the
logMessage
event in ts_xml 4.7.Code formatted by
black
, with a pre-commit hook to enforce this. See the README file for configuration instructions.
Minor changes:
- Fix bugs in
BaseCscTestCase.check_bin_script
and updatetest_csc.py
to call it. - Removed our local copy of
ddsutil.py
.
Requirements:
- black
- ts_idl 1
- ts_xml 4.7
- IDL files for Test, Script, and LOVE.
- SALPY_Test generated by ts_sal 4 (for unit tests)
v5.3.0¶
Major changes:
- Add
BaseCscTestCase
as a useful base class for CSC unit tests. Update the unit tests to use it.
Minor changes:
DefaultingValidator
now handles defaults in sub-objects (one level deep).- CSCs will now reject optional generic commands if not implemented (meaning there is no
do_
command method for them), instead of silently ignoring them. The optional generic commands areabort
,enterControl
,setValue
, and the deprecated commandsetSimulationMode
. - The
action
argument ofBaseCsc.assert_enabled
is now optional. There is no point to setting it when calling it fromdo_
command methods as the user knows what command was rejected. - If a command is rejected because a CSC is in
FAULT
state, the error message contains the current value of theerrorReport
field of theerrorCode
event. SalInfo
could not be created for a SAL component that had no commands (because such a component also has no ackcmd topic).
Deprecated APIs:
lsst.ts.salobj.test_utils
is deprecated. Please uselsst.ts.salobj
instead.
Requirements:
- ts_idl 1
- ts_xml 4.6
- IDL files for Test, Script, and LOVE.
- SALPY_Test generated by ts_sal 4 (for unit tests)
v5.2.1¶
Fix a call to warnings.warn
in Domain
.
Requirements:
- ts_idl 1
- ts_xml 4.6
- IDL files for Test and Script
- SALPY_Test generated by ts_sal 4 (for unit tests)
v5.2.0¶
Major changes:
- CSCs no longer support the
setSimulationMode
command, as per RFC-639.
Deprecated APIs:
- BaseCsc and ConfigurableCsc: the
initial_simulation_mode
constructor argument is deprecated in favor of the newsimulation_mode
argument. It is an error to specify both.
v5.1.0¶
Major changes:
- Provide IDL metadata, including descriptions of topics and descriptions and units of fields, via a new
SalInfo
metadata
attribute, an instance ofIdlMetadata
. Some of the metadata is only available in IDL files built with SAL 4.6. - Add the
AsyncS3Bucket
class for writing to Amazon Web Services s3 buckets.
Minor changes:
- Change a link in the doc string for
BaseCsc.handle_summary_state
to avoid Sphinx errors in subclasses in other packages. - Add a
done_task
attribute toDomain
. - Add an
isopen
attribute toController
. - Improve close methods for
Domain
,SalInfo
,Controller
andRemote
to reduce warnings in unit tests. Subsequent calls wait until the first call finishes andSalInfo
allows time for its read loop to finish.
Deprecated APIs:
SalInfo.idl_loc
should now beSalInfo.metadata.idl_path
.
Requirements:
- ts_idl 1
- IDL files for Test and Script
- SALPY_Test generated by ts_sal 4 (for unit tests)
v5.0.0¶
Update for ts_sal v4. This version cannot communicate with ts_sal v3 or ts_salobj v4 because of changes at the DDS level:
- The
ackcmd
topic has new fields that distinguish acknowledgements for commands sent by oneRemote
from those sent by another. - Command topics and the
ackcmd
topic now havevolatile
durability instead oftransient
. This means they cannot read late-joiner data, which eliminates a source of potential problems from stale commands or command acknowledgements. - The DDS queues now hold 100 samples instead of 1000.
Another backward incompatible change is that the setSimulationMode command can no only be issued in the STANDBY state. This makes it much easier to implement simulation mode in CSCs that connect to external controllers, because one can make the connection in the appropriate mode when in DISABLED or ENABLED state, without having to worry about changing it. This change may break some existing unit tests for CSCs that support simulation mode.
Deprecated APIs:
Specifying
code=None
forBaseCsc.fault
is deprecated. Please always specify an error code so theerrorCode
event can be output.BaseCsc.main
andBaseScript.main
are deprecated. Please replacecls.main(...)
withasyncio.run(cls.amain(...))
. This makes it much clearer that the call may not return quickly, avoids explicitly creating event loops, and takes advantage of the (new to Python 3.7) preferred way to run asynchronous code.Setting
BaseCsc.summary_state
is deprecated. In unit tests use the standard state transition commands or call theset_summary_state
function. In CSCs you should not be setting summary state directly; of the existing CSC code I’ve seen, most of it sends the CSC to a FAULT state, for which you should callBaseCsc.fault
, and the rest doesn’t need to set the summary state at all.Script commands
setCheckpoints
andsetLogLevel
are deprecated. Specify checkpoints and log level using the newpauseCheckpoint
,stopCheckpoint
andlogLevel
fields in theconfigure
command.Code that constructs a
Remote
orController
without a running event loop should be rewritten because it will break when we replace the remaining usage ofasyncio.ensure_future
with the preferredasyncio.create_task
. For example:csc = MyCscClass(...) asyncio.get_event_loop().run_until_complete(csc.done_task)
can be replaced with (see
BaseCsc.make_from_cmd_line
to add command-line arguments):asyncio.run(MyCscClass.amain(...))
New capabilities:
- Add function
current_tai
to return the current time in TAI unix seconds (LSST’s standard for SAL timestamps). - Enhance function
tai_from_utc
to support alternate formats for UTC using new argumentformat="unix"
. - Add
topics.ReadTopic.aget
to return the current sample, if any, else wait for the next sample (DM-20975). - Add coroutine
BaseCsc.handle_summary_state
. This is the preferred way to handle changes to summary state instead of overriding synchronous methodBaseCsc.report_summary_state
. - Add property
BaseCsc.disabled_or_enabled
which returns true if the current summary state isState.DISABLED
orState.ENABLED
. This is useful inBaseCsc.handle_summary_state
to determine if you should start or stop a telemetry loop. - Add
result_contains
argument toassertRaisesAckError
. - Enhance
topics.ControllerCommand
automatic acknowledgement for callback functions so that theack
value isSalRetCode
.CMD_ABORTED if the callback raisesasyncio.CancelledError
andSalRetCode
.CMD_TIMEOUT if the callback raisesasyncio.TimeoutError
. Controller.start
now waits for all remotes to start (except those constructed withstart=False
, which is rare).- Added
start_called
attribute toSalInfo
,Controller
andRemote
.
Other improvements:
Fix support for environment variable
LSST_DDS_IP
. The value is now a dotted IP address; formerly it was an integer.Improve error handling when specifying a non-zero index for a non-indexed SAL component (DM-20976). The
SalInfo
constructor will now raise an exception.Improve error handling in
BaseCsc.fault
. Report the problem and continue if the error code is not an integer, or ifBaseCsc.report_summary_state
fails.The unit tests use the
asynctest
package, which is pip installable.The documentation for
BaseCsc.main
now recommends specifyingindex=None or 0
for non-indexed components, instead ofNone or False
, in order to match standard usage in ts_salobj. All three values worked, and continue to work, but no existing code usedFalse
.Minor improvements to version handling:
- Set
lsst.ts.salobj.__version__
to “?” if running directly from source and there is noversion.py
file generated bysetup.py
orscons
. - Update
doc/conf.py
to get__version__
fromlsst.ts.salobj
instead oflsst.ts.salobj.version
.
- Set
Stop reading dead topics because ts_sal 4 no longer disposes of any samples immediately after writing. This removes a workaround added in v4.3.0.
Add this revision history.
Existing code is unlikely to require any changes to transition from salobj v4 to v5.
Communicates with ts_sal v4.
Requirements:
- ts_idl
- IDL files for Test and Script
- SALPY_Test generated by ts_sal v4 (for unit tests)
v4.5.0¶
Minor updates for ts_watcher and ts_salkafka:
Add several name attributes to topics:
sal_name
: the name used by SAL for a topic, e.g. “logevent_summaryState”.attr_name
: the name used by ts_salobj for topic attributes ofRemote
andController
e.g. “evt_summaryState”.dds_name
: the name used by DDS for a topic, e.g. “Test_logevent_summaryState_90255bf1”.rev_code
: the revision code that SAL appends to DDS topic names, e.g. “90255bf1”.
Remove the
attr_prefix
attribute from topics.
Communicates with ts_sal v3.10 (but not 3.9).
Requirements:
- ts_idl
- IDL files for Test and Script
- SALPY_Test generated by ts_sal v3.10 (for unit tests)
v4.4.0¶
Minor updates for ts_watcher:
Add support to
Remote
for adding topics after the object is constructed:- Change the meaning of constructor argument
include=[]
to include no topics. Formerly it would include all topics. - Add constructor argument
start
which defaults to True for backwards compatibility. Set it False if you want to add topics after constructing the remote.
- Change the meaning of constructor argument
Add function
name_to_name_index
for parsing SAL component names of the formname[:index]
.Add
attr_prefix
attribute totopics.BaseTopic
. Warning: this was replaced byattr_name
in v4.5.0.
Communicates with ts_sal 3.10 (but not 3.9).
Requirements:
- ts_idl
- IDL files for Test and Script
- SALPY_Test generated by ts_sal v3.10 (for unit tests)
v4.3.1¶
Make the unit test pass more reliably.
Warning: the unit tests only pass reliably if run using pytest
.
I still see a failure roughly 1/4 of the time when run using scons
.
This is probably a side effect of enabling code coverage analysis.
Other changes:
- Make
scons
optional by moving bin scripts frombin.src/
tobin/
and makingversion.py
optional. - Modify
BaseCsc.set_summary_state
to return a list of summary states. This is mostly for the sake of unit tests but it also tells callers what state the CSC started in.
Requirements:
- ts_idl
- IDL files for Test and Script
- SALPY_Test generated by ts_sal v3.10 (for unit tests)
v4.3.0¶
The first version that is truly compatible with ts_sal 3.10.
Fix an incompatibility with SAL 3.10:
- salobj could not reliably read ackcmd and command topics sent by SAL 3.10 because SAL 3.10 disposes those samples immediately after writing. Fixed by reading dead samples for those topics. This is intended as a temporary change until ts_sal is updated to not dispose samples after writing.
- Added a unit test for salobj<->SAL communication. Thus ts_sal is now an optional dependency of ts_salobj.
Requirements: - ts_idl 0.1 - SALPY_Test generated by ts_sal 3.10 (for unit tests)
v4.2.0¶
Warning: do not use this version because it is not compatible with ts_sal. Use v4.3.0 or later.
Add BaseScript (moved from ts_scriptqueue).
v4.1.1¶
Warning: do not use this version because it is not compatible with ts_sal. Use v4.3.0 or later.
Do not warn about the config labels file if empty. Only warn if the config labels file has data and that data cannot be parsed as a dict.
Other changes:
- Update log.warn to log.warning to fix deprecation warnings.
v4.1.0¶
Warning: do not use this version because it is not compatible with ts_sal. Use v4.3.0 or later.
Add evt_max_history
and tel_max_history arguments
to Remote
constructor.
v4.0.0¶
Warning: do not use this version because it is not compatible with ts_sal. Use v4.3.0 or later.
Compete rewrite to use OpenSplice dds instead of SALPY libraries generated by ts_sal. For more information see https://community.lsst.org/t/changes-in-salobj-4-the-dds-version/3701
To generate IDL files use command-line script make_idl_files.py
which is available in ts_sal 3.10.
For example:
make_idl_files.py Test Script